Warcraft II Forum

Warcraft II => Mods & Development => Topic started by: Delete mine too on February 06, 2016, 10:25:42 PM

Title: Fix for Build / Magic Crash
Post by: Delete mine too on February 06, 2016, 10:25:42 PM
I'm writing a program that we can use to fix that known crash with ctrl 1 and building and spells. Most time this bug comes up alot is when playing free castles or a map where you blizzard a lot and ctrl building. What i suspect happens if they didn't hit ctrl 1 fully and had a barrack for example on ctrl 1 so when they mage with blizzard and alt 1 the building tries to cast blizzard and the game crashes immediately.

This is ruined countless good games before and it will no longer be a problem soon. My program detects if a building is selected if so you cannot use a spell this will not effect game play at all just abuse or the random crash.
Title: Re: Fix for Build / Magic Crash
Post by: shesycompany on February 07, 2016, 03:59:51 AM
dam never seenthat :o,and i been sloppy as hell with ctrl 1.
Title: Re: Fix for Build / Magic Crash
Post by: EviL~Ryu on February 07, 2016, 04:59:59 AM
Weird..[emoji54]


Sent from my Motorola DynaTAC 8000X using Tapatalk
Title: Re: Fix for Build / Magic Crash
Post by: Delete mine too on February 07, 2016, 07:39:21 AM
It built it's self the name mage disconnect.

Ok think i got a good steady way to fix it. I can detect when a spell ready to be casted with mouse. They hit 1 and it selects the building they hotkeyed if a spell is detected it with change the spell to move or cancel. This won't mess with game play at all it will protect you from a crash or prevent you from abusing this bug with out cheats.
Title: Re: Fix for Build / Magic Crash
Post by: shesycompany on February 07, 2016, 07:06:51 PM
yup just need mpq side. we got another map maker dude in bnet zab something enthusiasm for this stuff  going to drink cant work
Title: Re: Fix for Build / Magic Crash
Post by: xboi209 on March 21, 2016, 08:49:26 PM
Any news on this?
Title: Re: Fix for Build / Magic Crash
Post by: Delete mine too on March 21, 2016, 09:24:24 PM
Done, iL made a patch so I didn't have to go my route. I can send you the link in pm for the thread.
Title: Re: Fix for Build / Magic Crash
Post by: shesycompany on March 22, 2016, 06:29:20 PM
gj!
Title: Re: Fix for Build / Magic Crash
Post by: Delete mine too on March 22, 2016, 10:00:00 PM
gj!

Yes I guess iL didn't know about this nasty bug or I brought it to his attention when I told him it ruins hundreds of free castles games.... I told him my idea that works and you know the pimp he is just was try thus simple method boom it works hands down. He could be my instructor for ASM... very fucking smart and glad he's our network admin. Im sure it will be added in a newer update for combat or for the anti hack loader depending on how he wants to apply the fix.

Would be nice if you could do that war1 conversion maybe add it as an option in the installer? I expect the next update to fix these.

1. Prevent a crash or abuse from an war2 bug.
2. New hacks detected..
3. The latest color fix
4. Command engine
5. Version of combat 15mb, 90mb music, 400mb full sounds, etc..
6. Maybe some custom MPQ options cough war1 TC cough.

Idk lots of stuff to add on next update. ;) I guess we will wait and see what he does.
Title: Re: Fix for Build / Magic Crash
Post by: shesycompany on March 22, 2016, 11:42:10 PM
naw tc's should be seperate ill get it done just holy shit modonna and beer is like seriously side tracking me
Title: Re: Fix for Build / Magic Crash
Post by: xboi209 on March 23, 2016, 12:12:06 AM
gj!

Yes I guess iL didn't know about this nasty bug or I brought it to his attention when I told him it ruins hundreds of free castles games.... I told him my idea that works and you know the pimp he is just was try thus simple method boom it works hands down. He could be my instructor for ASM... very fucking smart and glad he's our network admin. Im sure it will be added in a newer update for combat or for the anti hack loader depending on how he wants to apply the fix.

Would be nice if you could do that war1 conversion maybe add it as an option in the installer? I expect the next update to fix these.

1. Prevent a crash or abuse from an war2 bug.
2. New hacks detected..
3. The latest color fix
4. Command engine
5. Version of combat 15mb, 90mb music, 400mb full sounds, etc..
6. Maybe some custom MPQ options cough war1 TC cough.

Idk lots of stuff to add on next update. ;) I guess we will wait and see what he does.

I'm willing to help write the command engine if someone reverse engineers enough information
Title: Re: Fix for Build / Magic Crash
Post by: iL on March 23, 2016, 02:40:45 AM
Ops, missed this thread.
Yes, magic crash was my first experience with analyzing crash dumps on windows.

Blizzard didn't check addresses of their functions they call carefully, that caused crash. I hope i fixed their check, at least it stopped crashing for me.

Yes, i plan to add that code to new loader. Maybe to make a console application you should run after war2 is started while new loader is not ready.

Let me know if you know some other points in gameplay causing crash, maybe it's quite easy to fix them too.

Would be nice if you could do that war1 conversion maybe add it as an option in the installer?
I thought about an option in the combat installer to switch between war2/war1 textures after the project is finished. Of course if easycompany will not protest. Or make it some other way.

3. The latest color fix
I hope to get finished version that never crash, works as fast as possible and on all the computers ans OS'es the same way, then to include into new combat.
Maybe i need to make some tests myself for that. That is in my plans also.

4. Command engine
What i see is pvpgn-side php-based command engine. Maybe that would be a good way to public API and request modules from people who want to help? Need to think about that.
Title: Re: Fix for Build / Magic Crash
Post by: xboi209 on March 23, 2016, 04:32:22 AM
Quote from: tupac on March 22, 2016, 07:00:00 PM
4. Command engine
What i see is pvpgn-side php-based command engine. Maybe that would be a good way to public API and request modules from people who want to help? Need to think about that.
Not the best idea for something that modifies the client's memory, it'd be better to just hook the chat and work off of that.
Title: Re: Fix for Build / Magic Crash
Post by: iL on March 23, 2016, 04:48:03 AM
Not the best idea for something that modifies the client's memory, it'd be better to just hook the chat and work off of that.
Looks like i don't know something, i'm not about modify the client memory. My plan was to implement some new commands to server, for example /ss. Server receives that command from someone and then sends a command to antihack backend to request ss from players' antihacks. It's just an example, command engine will allow many different things not related to client's memory: to rewrite /whisper/ignore, /friends, /mail, /con, /ipban/hwban etc. To add many other user comands.

All these should be applied on the server only after my careful check.
Title: Re: Fix for Build / Magic Crash
Post by: Delete mine too on March 23, 2016, 05:11:44 PM
Not the best idea for something that modifies the client's memory, it'd be better to just hook the chat and work off of that.
Looks like i don't know something, i'm not about modify the client memory. My plan was to implement some new commands to server, for example /ss. Server receives that command from someone and then sends a command to antihack backend to request ss from players' antihacks. It's just an example, command engine will allow many different things not related to client's memory: to rewrite /whisper/ignore, /friends, /mail, /con, /ipban/hwban etc. To add many other user comands.

All these should be applied on the server only after my careful check.
Yes your end command engine is on the server side. Mine would be for client and I would like to be used single player/multiplayer.

I was able to reverse it for my CPU only and compile in .net a working version. I need to learn about aob+injection, etc to be able to use the chat box unless you know an easier way??
Title: Re: Fix for Build / Magic Crash
Post by: iL on March 23, 2016, 05:39:20 PM
unless you know an easier way??
I think no. I have no idea at all how to catch commands in single mode...
Title: Re: Fix for Build / Magic Crash
Post by: iL on March 23, 2016, 07:11:10 PM
Fix for crash released as a separate command-line application.
Start it, then run war2, it will wait until you start war2 and patch it then. Or start it after war2, it will patch war2 also.

Let me know if it works for you or cause any problems.

Up by il: removed as caused another crash, fixed version is released: http://forum.war2.ru/index.php/topic,2046.0.html (http://forum.war2.ru/index.php/topic,2046.0.html)
Title: Re: Fix for Build / Magic Crash
Post by: Delete mine too on March 24, 2016, 03:30:47 PM
2 downloads any reviews?

Edit:  I guess mousy said crashes when allies is clicked. Well I will try to test when I can.