Warcraft II Forum

Warcraft II => Server.War2.ru => Topic started by: iL on March 30, 2019, 01:00:00 PM

Title: War2Combat 4.4.3 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on March 30, 2019, 01:00:00 PM
Upd:
Updated Combat to 4.4.3:
    - One more fix for DEP
    - Some small installer improvements


Upd:
Updated Combat 4.4.1 to 4.4.2:
    - For CD-keys management compatibility, Warcraft II version changed from classic 2.0.2.1 to GoG 2.0.2.1
    now combat not requires to manage any CD-keys after being installed by GoG. It just uses GoG's cd-keys, together with GoG.
   GoG's KeyChanger added to combat.
    at the same time, install.exe have been renamed to install.mpq. (Also by GoG 2.0.2.1)
    - ddraw_test2 removed and replaced to ddraw_Aqrit by FunkyFr3sh (aka fois)
    That's sufficiently improved version based on test2.
    - ddraw_test4 removed and replaced to ddraw_CnC by FunkyFr3sh (aka fois).
    That supports OpenGL rendering with lots filters.


Previous post:
So, here's it:
    - Updated War2Ppatcher for 2.0.2.1 supporting warlat and resBug fix.
    - Updated War2PLoader for 2.0.2.1, removed antihack, removed autoupdate as attached to server.war2.ru

Added cd key changer autostart during installation. Path still should be fixed.

Get new versions from downloads secton!
Title: Re: War2Combat 4.4.1 released! warlat, resBug, uPNP, GoG server
Post by: outlaw[z] on March 30, 2019, 02:26:26 PM
Nice!!
Title: Re: War2Combat 4.4.1 released! warlat, resBug, uPNP, GoG server
Post by: baRa on March 30, 2019, 02:34:36 PM
I only see 4.4 in downloads? Wheres 4.41
Title: Re: War2Combat 4.4.1 released! warlat, resBug, uPNP, GoG server
Post by: outlaw[z] on March 30, 2019, 02:36:29 PM
Still need to change the CD key utility so when it saves file you don't have to select a new location. I think the is the most confusing part.
Title: Re: War2Combat 4.4.1 released! warlat, resBug, uPNP, GoG server
Post by: iL on March 30, 2019, 02:39:36 PM
I only see 4.4 in downloads? Wheres 4.41
It's it. I replaced it on ftp. I have no place to keep all versions there.

Still need to change the CD key utility so when it saves file you don't have to select a new location. I think the is the most confusing part.
CDkey changer autostarts during installation now. The problem is still to change path to proper. Still no solution for that.

Please, try that version as i didn't test it
Title: Re: War2Combat 4.4.1 released! warlat, resBug, uPNP, GoG server
Post by: outlaw[z] on March 30, 2019, 02:46:38 PM
Can you create a seperate Pop Up disclaimer that comes when you finish the installation? That sayor shows how to save the cd key.
Title: Re: War2Combat 4.4.1 released! warlat, resBug, uPNP, GoG server
Post by: iL on March 30, 2019, 03:12:03 PM
Can you create a seperate Pop Up disclaimer that comes when you finish the installation? That sayor shows how to save the cd key.
Let me try to do something....
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on March 31, 2019, 01:50:06 AM
Updated Combat 4.4.1 to 4.4.2:
    - For CD-keys management compatibility, Warcraft II version changed from classic 2.0.2.1 to GoG 2.0.2.1
    now combat not requires to manage any CD-keys after being installed by GoG. It just uses GoG's cd-keys, together with GoG.
   GoG's KeyChanger added to combat.
    at the same time, install.exe have been renamed to install.mpq. (Also by GoG 2.0.2.1)
    - ddraw_test2 removed and replaced to ddraw_Aqrit by FunkyFr3sh (aka fois)
    That's sufficiently improved version based on test2.
    - ddraw_test4 removed and replaced to ddraw_CnC by FunkyFr3sh (aka fois).
    That supports OpenGL rendering with lots filters.

Let's test ddraws by fois together!
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: fois on March 31, 2019, 07:36:31 AM
Nice!

There is still the problem with DEP, warcraft 2 is crashing if DEP is enabled. The war2 loader thing didn't use virtualprotect correctly if i remember right.

A user on gog found another problem in storm.dll where virtualprotect also wasn't used correctly, can you add that fix too?

You need to change 2 bytes in storm.dll: https://www.gog.com/forum/diablo/game_crashes_at_start/post27 (https://www.gog.com/forum/diablo/game_crashes_at_start/post27)



Edit:
I actually just tested this and I can confirm it does work! I enabled DEP, started the game -> crash... Changed the 2 bytes, started the game -> no crash :)
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: tk[as] on March 31, 2019, 12:29:55 PM
AVG antivirus HATES 4.4

(https://i.imgur.com/Z4ImJ1w.png)
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: baRa on March 31, 2019, 01:57:29 PM
So when you release these new versions every other day, does that mean I have to uninstall the previous version and download new one?
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: tk[as] on March 31, 2019, 02:49:01 PM
nope. You can use the old versions no problem
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 01:17:32 AM
The main goal for this last version on combat 4.4.2:
If you installed GoG war2 before, you typed proper working cd-key for it, and that means Combat 4.4.2 will use the same GoG's cd-key. No any reconfigurations requred anymore.
Designed to make migration War2GoG -> War2Combat transparent.

(At the same time if you never played GoG, but installed Combat, it will write it's unlegal blocked cd-key 6696-*, so you have to change it manually to play GoG, even if you install GoG after Combat. Combat also includes GoG's: C:\War2Combat\KeyChanger.exe to do that eigther using Combat or GoG.)

UPD: how it works:
classic war2bne keeps it's cd-keys in mpq-archives. GoG team made dirty hack on their .exe, and gog war2 now keeps it's cd-keys in the registry.
Combat follows the GoG client, so Combat since 4.4.2 also works with cdkey from the registry. And that means when you change the cd-key by gog's changer, cd-key will be changed for both gog and combat 4.4.2.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 01:27:16 AM
So when you release these new versions every other day, does that mean I have to uninstall the previous version and download new one?
Of course you should download and install new one!
About to uninstall or not to uninstall:
Combats are designed to be compatible to be overwritten on update between big versions.

If you install combat 4.3.2 (version of release 4.3) english version into C:\war2Combat43en and install combat 4.4.0 (version of 4.4) into C:\war2Combat44en (as i do), and then you will install combat 4.4.2, it will ask you to overwrite previous release of 4.4 release: to install C:\war2Combat44en, and that is recommended way.
Combat remembers installation folder between version of 1 release and asks you to install next 4.4.x to the previous 4.4 installation folder.

But you can also install combat 4.4.2 to common C:\war2combat folder with previous version 4.3.x or earlier. Everything should work properly even if didn't uninstall it before.

Common concept for all combats since 3.01:
You feel free to install any version of combat to a folder with previously installed combat of another version, everything will work fine, they will use saves and maps from previous installation in this folder.
At the same time, you feel free to install every combat version to different folder, then they will not interfere between folders.

Of course, installing combat into folder with GoG is not recommended (combat will work anyway though).
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: maciek on April 01, 2019, 05:24:31 AM
I entered my key to gog client and this key is already used
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: outlaw[z] on April 01, 2019, 05:31:06 AM
http://forum.war2.ru/index.php/topic,4853.0.html (http://forum.war2.ru/index.php/topic,4853.0.html) Look at my guide Maciek you have to click save right
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 05:33:24 AM
I entered my key to gog client and this key is already used
Did you enter your key using gog utility KeyChanger.exe?
Old cdkey changers will not work with gog client. Same as with lastest Combat 4.4.2.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Lambchops on April 01, 2019, 05:33:38 AM
AVG antivirus HATES 4.4


Yeah, you're getting a bit more red on virustotal.

At first glance, I'd guess that it's VirtualProtectEx. It has no purpose other than messing with the memory protection of another process, which will probaly cause heuristic results.

If you work from the inside you can just use VirtualProtect which won't be anywhere near as suspicious.


(http://forum.war2.ru/index.php?action=dlattach;topic=4859.0;attach=2968)
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 05:34:53 AM
[url]http://forum.war2.ru/index.php/topic,4853.0.html[/url] ([url]http://forum.war2.ru/index.php/topic,4853.0.html[/url]) Look at my guide Maciek you have to click save right

That method will NOT work with Combat 4.4.2 and GOG!
That will change the cd-key inside MPQ-archives, but GOG's version looks to the registry instead.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 05:38:57 AM
Yeah, you're getting a bit more red on virustotal.

At first glance, I'd guess that it's VirtualProtectEx. It has no purpose other than messing with the memory protection of another process, which will probaly cause heuristic results.

If you work from the inside you can just use VirtualProtect which won't be anywhere near as suspicious.
Thanks for your idea, i'll try that!

That's sad, but i have no idea how that can happen. I didn't add any new code to loader, i just removed some code, so that's strange. I'll try to update loader as soon as possible...
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Lambchops on April 01, 2019, 05:43:10 AM
Also looks like you are no longer using libcurl ... i think?  Maybe you no longer have to distribute the .dll
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Lambchops on April 01, 2019, 06:27:59 AM
Actually no, the noCDloader uses virtualprotectex and it only gets 2r on virustotal ... so idk ???

-- edit --


and the one engine that says v4.3 is "unsafe" doesn't detect v4.4 at all while 12 others do .... just shows you what garbage heuristic resluts are  ::)
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Lambchops on April 01, 2019, 07:52:42 AM
also the nocdloader is not needed wih the 4.4 client. :)
it already has the byte at 0x28E17 set to 0x00 so the nocdloader is doing nothing
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 08:52:52 AM
Also looks like you are no longer using libcurl ... i think?  Maybe you no longer have to distribute the .dll
You look into the table of functions used by loader? I don't remember exactly, but should be so.
I plan to restore antihack and other functionality based of new ideas, so... no i didn't remove a libcturl yet.

also the nocdloader is not needed wih the 4.4 client. :)
Yes, it was just lazy to remove the nocd loader this moment, i'm not sure how the project wil evolve in near future...
Maybe nocd will be required again soon.
I hate the idea to use gog exe modified by gog, i'd prefer clean 2021 or 2020, but there would not be ways to use gog cdkeys then.

just shows you what garbage heuristic resluts are
Yes, but the main question here is how to bypass that heuristic. That's the most important thing to distribute combat.
I'll try to make some tests when i'll be on place...
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Lambchops on April 01, 2019, 09:24:56 AM
Yes, but the main question here is how to bypass that heuristic. That's the most important thing to distribute combat.
I'll try to make some tests when i'll be on place..

For sure. We need to know what is causing it, so then we can work out how to bypass it. Suggest making lots of dummy .exe and test them.

Take out one part ... build and test .... take out the next part .... build and test etc. Until you know what is causing the alert, then we can get sneaky about it ;)

Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Sword::: on April 01, 2019, 10:56:28 AM
can u post the link here so i can download it bc its hard for me too find it pls ..
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 11:00:16 AM
can u post the link here so i can download it bc its hard for me too find it pls ..

It's in downloads section on our site: http://en.war2.ru/downloads/ (http://en.war2.ru/downloads/)
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 11:04:25 AM
Well, checked gog forum: https://www.gog.com/forum/warcraft_ii_battlenet_edition (https://www.gog.com/forum/warcraft_ii_battlenet_edition)
Many requests about different languages.
And no any requests about any languages here.
So, i removed all the 4.3 full versions and uploaded 4.4 full versions.
Will not work with existing war2insight, warvideo, war2observe, but will be compatible with GOG server, that is much more important for full version!
Feel free to play full versions compatible with GOG on: English, French, German, Italian, Polish, Russian, Spanish!
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: {Lance} on April 01, 2019, 11:25:56 AM
can u post the link here so i can download it bc its hard for me too find it pls ..

It's in downloads section on our site: [url]http://en.war2.ru/downloads/[/url] ([url]http://en.war2.ru/downloads/[/url])


That's the wrong link.  All it does is link to a file list of about 100 files that tells the user nothing about what to download.  It need ONE big button that says "Download Latest Version" and it needs to link to the ENGLISH 44 Standard version since that is what 99% of all users will want.  It's less maint for you and more clear to users what needs to be downloaded when you have current_version type download links.  The rest of them are for the VERY FEW users that use non-english hotkeys/test (and iL is in that category,  you are indeed a part of the minority) and if they are using those,  they will already know that they need to DL the correct language.

This is the correct link btw:  ftp://ftp.war2.ru/war2/War2Combat44_en.exe
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 11:53:19 AM
and it needs to link to the ENGLISH 44 Standard version since that is what 99% of all users will want.
Agree, but i'd recommend english 44 full version instead.
More 400Mb is nothing for most people, but they will have full game, with all videos, music and speeches.

Still going to make a beatiful download page when i have enough time, right after fixing loader false-positives i think...
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: {Lance} on April 01, 2019, 12:16:48 PM
As long as it links to the current version,  I dont think it would matter which of the lite/standard/full releases it is.  I do agree that a 400MB dl is small for many people now where as in the past it was not.  So either Standard or Full would work great.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: fois on April 01, 2019, 01:28:20 PM
You can have everything in 1 installer btw, just download the files the user wants during the installation. I use the inno download plugin from Mitrich Software for that.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 01:43:19 PM
You can have everything in 1 installer btw, just download the files the user wants during the installation. I use the inno download plugin from Mitrich Software for that.
Looks interesting, thanks for the idea!
I didn't know how to do that, but i thought about to download files during the installation process, but not sure that will be a good idea: that will mean installers could not be offline, they should depend on ftp.war2.ru, etc.
Maybe that problem could be resolved some way? So need to look and think...
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 01, 2019, 04:18:31 PM
At first glance, I'd guess that it's VirtualProtectEx
Finally you've been right.
I moved to previous release where i can see 12 virus errors with VirtualProtectEx and 2 wothout it.
What if just remove that call?
At least, some other soft works fine without it...
Updated loader to not cause false-positives, updated installers for 4.4.2, didn't increase version...
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: tupac on April 01, 2019, 07:50:53 PM
At first glance, I'd guess that it's VirtualProtectEx
Finally you've been right.
I moved to previous release where i can see 12 virus errors with VirtualProtectEx and 2 wothout it.
What if just remove that call?
At least, some other soft works fine without it...
Updated loader to not cause false-positives, updated installers for 4.4.2, didn't increase version...
Encrypt the .exe....
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Lambchops on April 01, 2019, 08:59:39 PM
At first glance, I'd guess that it's VirtualProtectEx
Finally you've been right.

Yeah I though I was wrong once, but that was an error ;)

I moved to previous release where i can see 12 virus errors with VirtualProtectEx and 2 wothout it.
What if just remove that call?

sounds like u will have 2r

At least, some other soft works fine without it...
Updated loader to not cause false-positives, updated installers for 4.4.2, didn't increase version...

cool :)

Like I say I can help you get around these issues, but if you're happy just removing it then its all good.

Encrypt the .exe....

antivirus doesn't like that.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Sword::: on April 02, 2019, 06:45:15 AM
itry joining  on gog  ut needs a new software nd says   downloading new sofware upgrade  but it is not downloading just stays ..no 100% complete nothing xd
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 02, 2019, 06:50:28 AM
itry joining  on gog  ut needs a new software nd says   downloading new sofware upgrade  but it is not downloading just stays ..no 100% complete nothing xd
Are you really trying 4.4.2 version?
Such software update request means you use improper version (combat 4.3 or less).
Make sure you really install combat 4.4. And after that you really start war2 from the folder where you installed it.

You can check combat installer version right/clicking the exe - properties - find the file information there. Should be 4.4.2. And You cat check Warcraft II BNE.exe properties. Should be 2.0.2.1 there.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Sword::: on April 02, 2019, 07:00:54 AM
LOOOOOOL nobody on gog is soo empty and more ulgy then ru xddd ru looks sexy xd
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: easycompany on April 02, 2019, 07:42:26 PM
there on now looks like burnt is trying to round them up.

hell 10 more people will be 10 more and most can make units..few im completely new people "heres a tower 3 grunts and a archer".
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: SD-ArchAngel on April 04, 2019, 02:32:35 PM
any attempt at all to fix the dual monitor problem on this.  game minimizes if you drag the cursor off window and click.  happens like 50x a game. need to disable 2nd monitor to play.
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: woofy on April 04, 2019, 03:27:19 PM
any attempt at all to fix the dual monitor problem on this.  game minimizes if you drag the cursor off window and click.  happens like 50x a game. need to disable 2nd monitor to play.

I noticed this too!!! So frustrating.  No issues in previous version.  Mouse focus is ALSO on Windows instead of confined to the game,  so when you click peasant to build hall, it tabs you out of the game
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: fois on April 04, 2019, 04:05:25 PM
I fixed the dual monitor problems already, see here:

http://forum.war2.ru/index.php/topic,1790.msg77472.html#msg77472 (http://forum.war2.ru/index.php/topic,1790.msg77472.html#msg77472)

You need to update file manually for now, I hope il can update the installer with the fixed version soon
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: woofy on April 04, 2019, 05:08:31 PM
Thanks. You're a legend
Title: Re: War2Combat 4.4.2 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 07, 2019, 06:03:36 AM
Updated installers on ftp, changed ddraw to last version. Didn't increase version, so it's still 4.4.2.
Title: Re: War2Combat 4.4.3 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: iL on April 11, 2019, 07:17:38 PM
4.4.3 released:
1 more fix for DEP: storm.dll patched, no reason to disable DEP anymore (didn't text, but should work).
fix for loader (changed possibly broken warlat/resbug). Should work fine.
added the link to war2.ru into installer.
small fix for mousey gateways (should be transparent for existing gateways list but write new gateways list for new installation).

Try it please!
You can download this version and install it overwriting previous 4.4.x build, as usual.
Title: Re: War2Combat 4.4.3 released! warlat,resBug,uPNP,GoG server,+CD-keys compatibility
Post by: Lambchops on April 12, 2019, 08:57:31 AM
1 more fix for DEP: storm.dll patched, no reason to disable DEP anymore (didn't text, but should work).
fix for loader (changed possibly broken warlat/resbug). Should work fine.

Cool :) Now you're on the right track.