Warcraft II Forum

Warcraft II => Server.War2.ru => Topic started by: Mistral on July 28, 2021, 02:46:42 PM

Title: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 28, 2021, 02:46:42 PM
Added Auto obs and teams feature to server.
Still in BETA test so will be many bugs - use with caution. IF you found a bug - please write. We need to fix all bugs.

How to use this:
1) its working ONLY in LOBBY.
2) its working ONLY for HOST.

host need to write
-team player_nickname team_id
where team_id can be from 0 to 9 or obs
0 is default (nothing changes)
1-8 will auto ally+viz other players of same team on game start
9 or OBS will become observer. They are spawned without any units and get auto viz from all players.

host additionally can write commands:
-check
-teams
to check mod version and teams of players

if you want you can write command like
-team slot_id team_id
where slot_id is player slot in lobby (its considered from PUD map colors)



P.S. examples of commands:
-team mistral OBS
-team MisTRal 1
-team 2 1
-team Droid 2
-team Droid obs
Title: Re: Auto obs + Auto teams {BETA test}
Post by: {Lance} on July 28, 2021, 03:51:22 PM
Very cool,  I can now allow all the retards to watch me smoke their buddies without them fuckin shit up :)

But you know whats missing?  HELP MENUS.  You cant make new features without help menus silly lol.  Other than Team 9,  what is the point of the other team settings?  Is it just to vis others?  If so,  TVB already does that.  A usecase could be to attach it to the Teams Ladder which is what I had done decades ago when I did the same thing as this :)

Anyway,   good job redeveloping my idea.  It's great to see it finally implemented on a server thats sort of in use (population is really lacking these days).
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on July 28, 2021, 03:54:13 PM
Wow, that looks really cool. I do see that you still have the option to ally/share vision though.

What happens when you ally/share vision?

Does the game not end unless the obs are allied/AV? If not, that will pose a problem unless you can somehow do something similar to killing their peon to end it.

Teams 2 1 would mean that player is on 2 both teams at the same time?

Once this is fully implemented, spb is going to shit his pants. :)
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Available on July 28, 2021, 04:03:12 PM
what is the point of the other team settings
To have any number of teams, like 2x2x2x2 etc.


Teams 2 1 would mean
that player in slot 2 belongs to team 1.

Does the game not end unless the obs are allied/AV
Once there are no players, observers leave.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: {Lance} on July 28, 2021, 04:12:49 PM
Does the game not end unless the obs are allied/AV
Once there are no players, observers leave.

Harry brings up a good point.  So are you trying to say that if there is only 1 TEAM left?  IE:  Players from team 2,3,4,5,6,7,8 have all left,  Players from team 1 are still in the game (assuming Team 1 are the winners of course),  and Players from team 9 (OBS) are also still in the game,  == The game ends?

what is the point of the other team settings
To have any number of teams, like 2x2x2x2 etc.

Just trying to figure out what this could be useful for since setting teams like that is already possible without any extra code.  So far the only thing I can think of is a way to force the game to end when there are observers who dont want to leave which I think you're trying to say is already baked in (which is great if that is indeed the case).

BTW,  I like the X on the msg you print.  It's reminiscent of the old DOS version where the word "xin" was actually a thing :)  You're probably to young to realize the subtleness of that nostalgic piece but now you know ;)
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 28, 2021, 04:24:52 PM
those teams thing only making changes BEFORE game started
teams NOT changes anything DURING game itself
you CAN set on or off any shared vision and ally and AV
shared vision for OBS will be reset though

only thing its makes for obs is that they not leave game even if have 0 units. (but they will leave anyways if there is no other players)

this thing is basically are recreation of team selections like in Warcraft 3 (like Clan1 Clan2 and etc)

and as Avail said you can make 2x2x2x2 or something
and other thing is that you can actually bring COMPS into team with players too
or make comps fight with other comps etc (still have some bugs though)
Title: Re: Auto obs + Auto teams {BETA test}
Post by: {Lance} on July 28, 2021, 04:38:33 PM
Ahh ok,  well the comps bit is something interesting.  I've never actually played a team or 1v1 game where a CPU was my ally.  IDK if I'd even want that.  The CPU SUCKS and would be a complete waste of a mine hehe.  Arent there custom maps that have a CPU as your ally?  I've never played one but I'm sure such a monster exists by now lol.

So what happens to records if everyone leaves except the observers?  Do the winning players get a loss?
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 28, 2021, 04:51:31 PM
From my side winning players get win 100% (and obs too)
i mean in status screen there will be written "Victory"
but i dunno how ladder works
iL said that server just reads reports - and i think that in report winning player should win too even if he leaved before observers.

This is why i said its BETA version and needs testing and many bugs fixing  :)
Title: Re: Auto obs + Auto teams {BETA test}
Post by: {Lance} on July 28, 2021, 05:02:37 PM
For the win I wasnt referring to the Web based ladder system.  I was referring to the War2 Victory/Defeat screen.  As long as it shows the victory screen regardless of what the Observer selects in the "Ally" screen, then thats cool.  Otherwise,  it would need work :)  Cuz we all know Van is going to find a way to be a total dick if he's still allowed to watch games and this doesnt work as intended lol.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: maciek on July 28, 2021, 05:55:20 PM
finally watchers are able to watch 2v2 chop farms games, good work
Title: Re: Auto obs + Auto teams {BETA test}
Post by: tk[as] on July 28, 2021, 06:23:49 PM
You get a loss every time you're designated as a watcher.. but still get victory screen.

If you talk in game as a watcher, the players hear you, but you can't hear anyone in game chatting

Nothing happens if you give vision as a watcher

I think game crashes if non-host types the "-team (user)- obs" command
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 29, 2021, 04:27:40 AM
1) dunno about obs loss - should get win. I will check it and try fix if real.

2) I know about chat problems they was here from the start - still trying to fix. (tis is the most thing why i said this is still beta test)

3) All working ok cuz obs NOT have ANY units that can give any viz so ofc noting changes

4) 100% should not be crash - i just calling standart war2 dialog with text "This command only for host!". I doubt it can cause crash cuz its a standart dialog. It the same dialog as when you press button OK in lobby and its saying that map being distrib, I just changed text on it.
Will attach screnshoot with it.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: tk[as] on July 29, 2021, 10:33:39 AM
I'm just noting my observations.

Cool feature if the bugs get worked out. Getting the losses is the biggest issue I noticed.

I typed the command as a non-host and the game crashed. Maybe it was just coincidence

It does suck you cant hear the players chat. Idk if that can be fixed.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 29, 2021, 10:47:52 AM
Where exactly you mean obs get defeat?
After all other players left game? there is should be 100% win i checked it 3 times.

Maybe you mean they receive loss when they leave game before other players? like u know they press button "surrender" in menu?

about crash i dunno. Are you got crash just one time or it is every time? Cuz if yes then i will need to fix it somehow too.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Droid on July 29, 2021, 11:50:12 AM
Teams 2 1 would mean
that player in slot 2 belongs to team 1.
The counting starts at 0, so there are 0 1 2 3 4 5 6 7 slots.

-team 2 1
(someone from the 3rd slot is in team 1 now)

(https://sun2-4.userapi.com/impg/_F4Pu8im56SigkTqe-xFJEVaE6EMmDsEghTv1Q/T0km9SDvlwQ.jpg?size=335x247&quality=96&sign=b8cdd9d0c21e46f08380f868b8557c68&type=album)

Maybe add +1 to slot counter in your code to make it more user-friendly?
1 2 ... 8
So all alternatively gifted GOW players (and Nazi too) can set the teams EZ.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Certified MENSA Genius Brain (smart) on July 29, 2021, 12:41:57 PM
anyway to expand this tech so, for example, players 5 6 7 8 can join a four player map, and are automatically OBS
Title: Re: Auto obs + Auto teams {BETA test}
Post by: tk[as] on July 29, 2021, 10:30:51 PM
I made smurf account. Joined 4 games where I was designated as watcher. Got victory screen on all 4 games. My record was 0-4.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 30, 2021, 05:20:37 AM
oohh u meant stats. Actually i not checked how they counts ) Just thinked if there was victory screen then all ok.
Actually i dnt know how exactly server counts those.

I will try to change way that obs works. Instead of 0 units will try to make 1 but hidden unit and they will always be allied and AV to all other players. So they will "win" game with winning players instead of leaving game after them.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Delete mine too on July 30, 2021, 11:52:40 AM
oohh u meant stats. Actually i not checked how they counts ) Just thinked if there was victory screen then all ok.
Actually i dnt know how exactly server counts those.

I will try to change way that obs works. Instead of 0 units will try to make 1 but hidden unit and they will always be allied and AV to all other players. So they will "win" game with winning players instead of leaving game after them.
Would be best too find that two minute counter so viewers get draw. Good work mistral!!!
Title: Re: Auto obs + Auto teams {BETA test}
Post by: {Lance} on July 30, 2021, 03:13:47 PM
A draw for being an Observer seems like a good compromise but Jade will hate you forever ;)
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 30, 2021, 03:51:41 PM
So after i changed 0 units to 1 hidded unit seems like many bugs was fixed.  :thinking: :thinking:

I tested just now with Kariu and GlassOfWater

1) Chat working normally 100%  :newthumbsup:

2) I was obs in 2 games and in one game my stats not changed (i think cuz there was comp in this game)
and in other game i got +1 win  :chuckisthemuscle:

3) one of games was GOW and they hosted it in TVB mode and i was OBS. There was also He-Man and iSuck[is] and they played 2s with Kariu and GlassOfWater
and so they asked where was my spot but other 2 did not even know this cuz i was obs and my 1 unit was hidded.  :stuck_out_tongue:
So what i wanted to say is that this new feature seems like helping to make real OBS in TVB too :)
i mean to make obs that do not "give away" spots.  :thumbsup:

4) one of games was with comp and we had sucsessfully paired real player with comp in one team (with ally and viz)
but the problem is that they still need to kill that comp to win game so i will try to fix this bug next  :hug:
Title: Re: Auto obs + Auto teams {BETA test}
Post by: 8)MikulZ(8 on July 30, 2021, 04:17:55 PM
At last there can be watchers on chop!!!!! awesome job Mistral like always  :chuckisthemuscle: 8)
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Rareskills on July 30, 2021, 06:22:14 PM
Draw for obs should be going in position, why should you get a W or L just for watching haha
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on July 31, 2021, 10:41:40 AM
Ok seems like fixed a thing with comps.
now you can play and WIN games with allied comps without killing them.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: eleison on July 31, 2021, 01:19:05 PM
Good job!! :) Can we put "observer" in the race menu? Instead of typing commands...
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 01, 2021, 06:29:28 AM
ok there is update

1) fixed a bug when hidden unit of obs sometimes may start attacking other players buildings.

2) observers now can see other players resources and what they build (like in observe program)

3) added command "/obs player_color" for host
host can use it during the game to make player into obs.

4) added command "/remove player_color" for host
host can use it during the game to remove player from game.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: fois on August 01, 2021, 06:46:56 AM
It's cool, but I don't like that you have to type commands :(

When you have to type commands it will be too complicated and many will not use it, just like it was some years ago with the host bots.


It would be nice if we can have observers working without commands, the drop down box should have the observer setting in it so you get "human, orc, random, observer"
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 01, 2021, 06:58:32 AM
the problems with this is

1) gluchat.bin are in MPQ so if we change it then all ppl will need to download this file to put into their MPQ.

2) i found function that calls when you click checkbox. but i still cannot find combobox (like a list with races) and i cannot find a way to add something to this combobox.

if you know how to do it then write me pls
Title: Re: Auto obs + Auto teams {BETA test}
Post by: tk[as] on August 01, 2021, 10:01:16 AM
Awesome progress resolving some of these issues.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on August 02, 2021, 10:05:39 AM
Can't describe how much you are helping the game with all of this.

Yes, the new commands are a bit to learn but as people have seen the functions live they go "WOW". It'll catch on enough that people WANT to do it and will learn it. I've been using it and it's great. (dropped once though only yesterday)

So, you can kick people from games now as host? Clan DD is in trouble. Also, maybe that function should only be for obs or something? I see that function being abused for sure.

What are the conditions for making a player obs mid game? Or I guess, what would be the reasoning for the function?

No sense in doing it 5mins into the game or 1min into the game if they are playing (bad spot, ooops). If you do this and the player already made buildings, what happens to the buildings? If a player was formerly playing on a team and let's say he has 1 peon left and asks to obs, then they will see other team's resources so that wouldn't work. I can think of other ways to abuse it but prefer not to say it.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Droid on August 02, 2021, 02:43:16 PM
MISTRAL U GOTTA ALLOW THE OBS COMMAND TO ALL PLAYERS NOT JUST HOSTS. SOME HOSTS JUST ARENT LISTENING & DUNNO THE NEW FEATURES.

PLS LET ALL THE PLAYERS USE THE TEAM-OBS COMMAND.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Player on August 02, 2021, 03:09:31 PM
MISTRAL U GOTTA ALLOW THE OBS COMMAND TO ALL PLAYERS NOT JUST HOSTS. SOME HOSTS JUST ARENT LISTENING & DUNNO THE NEW FEATURES.

PLS LET ALL THE PLAYERS USE THE TEAM-OBS COMMAND.

Bad idea.  Host only.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Rareskills on August 02, 2021, 03:57:06 PM
If any player can only make themselves an obs, I think this is a great idea.

Maybe it was covered in an earlier post, but when happens if an obs lag, and they are a hidden obs, they go afk so you can't kill them...is this just something we have to deal with?
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on August 02, 2021, 05:30:29 PM
MISTRAL U GOTTA ALLOW THE OBS COMMAND TO ALL PLAYERS NOT JUST HOSTS. SOME HOSTS JUST ARENT LISTENING & DUNNO THE NEW FEATURES.

PLS LET ALL THE PLAYERS USE THE TEAM-OBS COMMAND.

Bad idea.  Host only.


Bad idea. Host only.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Szwagier on August 02, 2021, 06:18:06 PM
Players should be able use only obs command but only on yourself

kick only host
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on August 04, 2021, 01:52:32 AM
Might be a good idea to have a -reset or something. I can see melee and stuff getting messed up a lot and then people are lost about what is going on in the lobby. IE: He will watch, now he has to go, you watch, no, i will watch instead, let's 3s now and not 2s, etc, etc.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: ~ToRa~ on August 04, 2021, 09:07:13 AM
MISTRAL U GOTTA ALLOW THE OBS COMMAND TO ALL PLAYERS NOT JUST HOSTS. SOME HOSTS JUST ARENT LISTENING & DUNNO THE NEW FEATURES.

PLS LET ALL THE PLAYERS USE THE TEAM-OBS COMMAND.

Yeah only the host or players should be able to use it on themselves.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 04, 2021, 05:22:01 PM
Added menu on the left in lobby.
use it to change teams.

say pls if you found some bugs and etc.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Available on August 04, 2021, 05:51:40 PM
Non-obvious convenient feature:

Right-click on the team field to configure the player as an observer,
so host can fast set observers then start without opening any dropboxes.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Player on August 04, 2021, 07:07:28 PM
That is badass.  Good stuff.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Player on August 04, 2021, 07:46:48 PM
Probably don't need all the text showing what teams were set now since you see it on the drop down next to the name.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on August 04, 2021, 10:08:35 PM
The dropbox answer is above. He addressed it. Would be real nice though. I agree.

The Obs icon is pretty cool feature. The teams thing is unnecessary and creates a lot of spam. Every time we tried to use obs on TVB host dropped today.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 05, 2021, 12:39:13 AM
Ye it was a little bug that they was sended to chat.

Now should be fixed.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 05, 2021, 12:50:22 AM
Every time we tried to use obs on TVB host dropped today.
Hmm need more tests...
It was ONLY on tvb  or melee too maybe ?

And maybe someone maked /ignore to host? Or host to someone
Cuz for now all info being send trough chat. Just invisible (ye there was bug that they was visible last night).

Cuz for now i dnt know how else to send info
I trying to find a way to send some packets instead.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on August 05, 2021, 02:00:58 AM
We did it 3-4 times in a row on TVB and then gave up. We did not do melee. We had 2 different hosts do it. It did show in the chat that I was obs and another person was as well, the "obs" text was on the far left but it dropped still and only the host dropped.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: eleison on August 07, 2021, 05:14:45 PM
Thank you for working on this. Could you make it possible to host a 1v1 map with 8 spots? That would make a huge improvement to game!
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 08, 2021, 10:20:29 AM
fixed graphicks for those lists a little.

and fixed observing comps ffa.
now you can obs when there is only comps in game and you as obs win game only when some team of comps win.
(only when comps is still alive that are all allied betwen themselves)
actually dunno if this function can be useful but U8 asked about this very much so i maked it.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Dudakurten on August 09, 2021, 10:00:25 AM
What a good job Mistral. You are the best !
Title: Re: Auto obs + Auto teams {BETA test}
Post by: LoRyS.iT on August 09, 2021, 12:07:04 PM
great job
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Dudakurten on August 09, 2021, 01:08:09 PM
Please let us know if worked add more players as an observers in a 2 or 4 slot map.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 11, 2021, 09:18:03 AM
fixed bug when host can sometimes drop if players who was obs changes race after game start
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Nox on August 11, 2021, 09:24:39 AM
btw your add on dosent work with french version 4.6.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 11, 2021, 10:37:15 AM
hi thanks
now all should be fixed for french version (and prob for others langs too)
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on August 11, 2021, 10:52:40 AM
Okay guys there is info for ALL

we just tested with Equinox and it seems like old CNC ddraw.dll can cause bugs and some things will not be working.
so if you use old ddraw then better to download new War2Combat from site and reinstall.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Zelya on September 07, 2021, 12:00:08 PM
Mistral, does your obs feature work with any PVPGN or only with modified one? We usually use local old PVPGN server for LAN playing and I wonder if we can use new combat versions?
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Mistral on September 07, 2021, 04:11:57 PM
should work on any cuz its not from pvpgn itself.
and should not matters if war2 is combat or not - only matters if its exe version 2.0.2.0 - so GOG will not work cuz its 2.0.2.1

Zelya напиши мне в вк я покажу как установить мод на pvpgn
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on November 02, 2021, 03:36:32 PM
While the ideas are flowing, I wanted to give some feedback on the obs feature I've been meaning to say.

It's obviously great. Everyone uses it and loves it. The only thing I think that could be improved is mid-game obs. Historically, when people say, "last", the other team allies them with no vision allowing them to watch the rest of the game, with their teams vision only, without being eliminated. (also you doofs do it when someone has 20 blds still for some ungodly reason- side rant)

It's more of a unwritten rule that when you are obsing (saying "last" before the new feature came around) you can still only see your team and it's okay to verbally help them. But when you use the new obs feature mid-game, you can now see everyone's vision. So, now it's like an ethical dilemma because now you really shouldn't say anything.

So, if there could be something where, when you use the obs feature, it only shows who you are allied to. There is probably a better way though, as you can ally someone before you say "obs me". It would also screw over the people in melee who did not get obsed in the lobby on accident. It was an example but, you get the point.

@Mistral
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Szwagier on November 02, 2021, 07:18:39 PM
You cant tip if you see all map, maybe except your peons are blocked, you care about stats?
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Harrywangs on November 03, 2021, 12:09:38 AM
You shouldn't tip your own team if you see the whole map, right.

Could you though? Sure.

Could you if you can't see them? No

I'm not sure what this has to do with stats.
Title: Re: Auto obs + Auto teams {BETA test}
Post by: Warbux on November 03, 2021, 07:32:45 PM
wow i just tested this it works in melee to .. really awesome great work!!